Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: permissions missed after workspace update #245

Merged

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Oct 27, 2023

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Lin Wang <wonglam@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

Merging #245 (a0ff20f) into workspace (f4dfa30) will decrease coverage by 0.01%.
Report is 1 commits behind head on workspace.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           workspace     #245      +/-   ##
=============================================
- Coverage      66.24%   66.24%   -0.01%     
=============================================
  Files           3438     3438              
  Lines          66266    66266              
  Branches       10696    10696              
=============================================
- Hits           43901    43899       -2     
+ Misses         19758    19679      -79     
- Partials        2607     2688      +81     
Flag Coverage Δ
Linux_1 30.88% <ø> (ø)
Linux_2 55.42% <ø> (ø)
Linux_3 42.77% <ø> (-0.01%) ⬇️
Linux_4 34.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/plugins/workspace/public/workspace_client.ts 71.42% <ø> (ø)

... and 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Lin Wang <wonglam@amazon.com>
@wanglam wanglam marked this pull request as ready for review October 27, 2023 09:41
@wanglam wanglam merged commit dc240eb into ruanyl:workspace Oct 27, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants