Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cypress tests checkout workspace branch #252

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Feb 27, 2024

Description

Change default FT Repo branch to workspace

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Lin Wang <wonglam@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.02%. Comparing base (089ad04) to head (ec966e1).

Additional details and impacted files
@@                 Coverage Diff                  @@
##           workspace-pr-integr     #252   +/-   ##
====================================================
  Coverage                67.02%   67.02%           
====================================================
  Files                     3318     3318           
  Lines                    63965    63965           
  Branches                 10255    10255           
====================================================
+ Hits                     42871    42872    +1     
  Misses                   18585    18585           
+ Partials                  2509     2508    -1     
Flag Coverage Δ
Linux_ 66.35% <ø> (+<0.01%) ⬆️
_1 35.41% <ø> (ø)
_2 55.30% <ø> (ø)
_3 43.42% <ø> (-0.01%) ⬇️
_4 35.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanglam wanglam marked this pull request as ready for review February 27, 2024 10:13
@wanglam wanglam requested a review from SuZhou-Joe as a code owner February 27, 2024 10:13
@wanglam wanglam merged commit 734c890 into ruanyl:workspace-pr-integr Feb 27, 2024
46 of 48 checks passed
opensearch-workspace-development bot pushed a commit that referenced this pull request Feb 27, 2024
Signed-off-by: Lin Wang <wonglam@amazon.com>
(cherry picked from commit 734c890)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
wanglam pushed a commit that referenced this pull request Feb 28, 2024
(cherry picked from commit 734c890)

Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl added a commit that referenced this pull request Mar 7, 2024
ruanyl added a commit that referenced this pull request Mar 7, 2024
…n management and SavedObject management as standalone app, retire dashboard management (#283)

* Revert "Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management (#208)"

This reverts commit 5f09f84.

* Revert "feat: add unit test for mountWrapper (#223)"

This reverts commit a70ce71.

* Revert "fix: cypress tests checkout workspace branch (#252)"

This reverts commit 734c890.

* run cypress with ftr main

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Mar 11, 2024
…n management and SavedObject management as standalone app, retire dashboard management (#283)

* Revert "Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management (#208)"

This reverts commit 5f09f84.

* Revert "feat: add unit test for mountWrapper (#223)"

This reverts commit a70ce71.

* Revert "fix: cypress tests checkout workspace branch (#252)"

This reverts commit 734c890.

* run cypress with ftr main

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Mar 18, 2024
Signed-off-by: Lin Wang <wonglam@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Mar 18, 2024
…n management and SavedObject management as standalone app, retire dashboard management (#283)

* Revert "Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management (#208)"

This reverts commit 5f09f84.

* Revert "feat: add unit test for mountWrapper (#223)"

This reverts commit a70ce71.

* Revert "fix: cypress tests checkout workspace branch (#252)"

This reverts commit 734c890.

* run cypress with ftr main

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants