Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove useless code #258

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

SuZhou-Joe
Copy link
Collaborator

@SuZhou-Joe SuZhou-Joe commented Feb 28, 2024

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.70%. Comparing base (4eb3548) to head (8d6222d).

Additional details and impacted files
@@              Coverage Diff               @@
##           workspace     #258       +/-   ##
==============================================
+ Coverage      55.60%   66.70%   +11.10%     
==============================================
  Files           2260     3336     +1076     
  Lines          42470    64764    +22294     
  Branches        7539    10439     +2900     
==============================================
+ Hits           23616    43204    +19588     
- Misses         17394    18978     +1584     
- Partials        1460     2582     +1122     
Flag Coverage Δ
Linux_1 31.06% <ø> (?)
Linux_2 55.17% <ø> (ø)
Linux_3 41.70% <ø> (?)
Linux_4 34.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 8de7956 into ruanyl:workspace Feb 28, 2024
32 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants