Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: consume current workspace in saved objects management and saved objects client #261

Conversation

SuZhou-Joe
Copy link
Collaborator

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

… objects client

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 76.27119% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 66.94%. Comparing base (9168d9b) to head (d57a2ab).

Files Patch % Lines
...ment_section/objects_table/saved_objects_table.tsx 80.00% 1 Missing and 2 partials ⚠️
...d_objects_management/server/routes/scroll_count.ts 0.00% 3 Missing ⚠️
src/plugins/workspace/public/plugin.ts 71.42% 1 Missing and 1 partial ⚠️
.../core/public/saved_objects/saved_objects_client.ts 95.83% 1 Missing ⚠️
...ment/public/lib/fetch_export_by_type_and_search.ts 0.00% 1 Missing ⚠️
...ects_management/public/lib/fetch_export_objects.ts 0.00% 1 Missing ⚠️
...saved_objects_management/public/lib/import_file.ts 0.00% 0 Missing and 1 partial ⚠️
...cts_management/public/lib/resolve_import_errors.ts 0.00% 0 Missing and 1 partial ⚠️
...ins/saved_objects_management/server/routes/find.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           workspace-pr-integr     #261      +/-   ##
=======================================================
- Coverage                67.02%   66.94%   -0.08%     
=======================================================
  Files                     3318     3322       +4     
  Lines                    63965    64139     +174     
  Branches                 10255    10289      +34     
=======================================================
+ Hits                     42871    42938      +67     
- Misses                   18585    18687     +102     
- Partials                  2509     2514       +5     
Flag Coverage Δ
Linux_ 66.27% <76.27%> (?)
_1 31.70% <16.21%> (-3.72%) ⬇️
_2 55.34% <96.00%> (+0.04%) ⬆️
_3 43.40% <0.00%> (-0.03%) ⬇️
_4 35.17% <29.41%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe changed the title Feature/current workspace in saved objects client main feat: consume current workspace in saved objects management and saved objects client Feb 29, 2024
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe merged commit 57ee06d into ruanyl:workspace-pr-integr Mar 1, 2024
44 of 45 checks passed
SuZhou-Joe added a commit that referenced this pull request Mar 18, 2024
… objects client (#261)

* feat: consume current workspace in saved objects management and saved objects client

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add unit test for each change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: update snapshot of unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants