Merge PR 5949 and sync up main #273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roject#5915) Update the screenshots for area and tsvb related to functional tests. Updated with: yarn test:ftr --updateBaselines --include ciGroup3 Issues: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
…5926) Bumps chromdriver dependency causing errors during bootstrap due to URL change. Issues Resolved: opensearch-project#5925 Signed-off-by: Derek Ho <dxho@amazon.com>
…delimiter to double colon (opensearch-project#5907) * concatenate data source name with index pattern name Signed-off-by: Lu Yu <nluyu@amazon.com> * add changelog Signed-off-by: Lu Yu <nluyu@amazon.com> * add tests Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com>
…egistry (opensearch-project#5881) * Refactor getClient and getLegacyClient to use authentication method registry Signed-off-by: Bandini Bhopi <bandinib@amazon.com> * Adds changelog and UT Signed-off-by: Bandini Bhopi <bandinib@amazon.com> --------- Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
…shboard (opensearch-project#5934) Remove default sort to use saved search sort. Issue Resolve opensearch-project#5933 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Update changelog placing 2.12 into it's own section. Issue: opensearch-project#5257 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
* add key to index pattern options for support duplicate index pattern names --------- Signed-off-by: Eric <menwe@amazon.com>
* [Discover] Fixes safari overflow bug --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Miki <amoo_miki@yahoo.com>
…earch-project#5944) * fix missing param and add changelog and test Signed-off-by: Lu Yu <nluyu@amazon.com> * change pr number Signed-off-by: Lu Yu <nluyu@amazon.com> * remove dangling changelog Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
…passed for the dataSourceId. (opensearch-project#5882) * [MD] Using legacy client cofig instead of globle config Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] add test cases to test different hostconfig and datasourceId combinations of scenario Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * Update changelog file Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * Resolve comments Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] update test cases and resolve comments Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] Update unit test Signed-off-by: Xinrui Bai <xinruiba@amazon.com> --------- Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
…#5970) Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
…ng numerals (opensearch-project#5956) Signed-off-by: Miki <miki@amazon.com>
…configuration (opensearch-project#5916) * [AuthType Config] Add EnabledAuthType configuration in yml file and pass value to dataSourceManagement root mount Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [AuthType Config] provide default auth types when types array is empty Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [AuthRegistry Onboard - DataSourceCreationForm] Integrate auth cofig with AuthRegistray and providing data source options from AuthRegistry Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [AuthRegistry Onboard] Support default selected auth type in datasource creation page Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [AuthRegistry Onboard] SDisable auth option selector when auth options no more than 1 Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [AuthRegistry Onboard] clear credential attribute every time use select NoAuth option. Also update credentialField data type Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * Update yml file to disable config Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * Update change.md file Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] Fix broken test cases Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] Add more unit tests Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] update unit test and handle scenario when no options enabled Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] update description of unit test case Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] update unit test cases to resolve comment Signed-off-by: Xinrui Bai <xinruiba@amazon.com> * [UT] Snapshot auth option super selector for unit test. Also upate the default message in datasorurce creation form ---> auth type section Signed-off-by: Xinrui Bai <xinruiba@amazon.com> --------- Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
* feat: add ruanyl as a maintainer Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add CHANGELOG Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
* add BionIT as a maintainer Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com> * update pr link in the changelog.md Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com> --------- Signed-off-by: Flyingliuhub <33105471+flyingliuhub@users.noreply.github.com>
…th type (opensearch-project#5997) * fix schema for test connection Signed-off-by: Lu Yu <nluyu@amazon.com> * add changelog Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com>
…t#5855) * Add application configuration service Signed-off-by: Tianle Huang <tianleh@amazon.com> * update API path name Signed-off-by: Tianle Huang <tianleh@amazon.com> * implement two APIs/interfaces Signed-off-by: Tianle Huang <tianleh@amazon.com> * expose get function for other plugins to use Signed-off-by: Tianle Huang <tianleh@amazon.com> * update interfaces Signed-off-by: Tianle Huang <tianleh@amazon.com> * implement the APIs and interfaces Signed-off-by: Tianle Huang <tianleh@amazon.com> * add license and jsdoc Signed-off-by: Tianle Huang <tianleh@amazon.com> * update docs Signed-off-by: Tianle Huang <tianleh@amazon.com> * add more docs Signed-off-by: Tianle Huang <tianleh@amazon.com> * update variable name Signed-off-by: Tianle Huang <tianleh@amazon.com> * remove unnecessary dependency Signed-off-by: Tianle Huang <tianleh@amazon.com> * format readme Signed-off-by: Tianle Huang <tianleh@amazon.com> * use osd version Signed-off-by: Tianle Huang <tianleh@amazon.com> * remove debugging info Signed-off-by: Tianle Huang <tianleh@amazon.com> * update logging Signed-off-by: Tianle Huang <tianleh@amazon.com> * remove lint js Signed-off-by: Tianle Huang <tianleh@amazon.com> * remove logs Signed-off-by: Tianle Huang <tianleh@amazon.com> * update name style Signed-off-by: Tianle Huang <tianleh@amazon.com> * update Signed-off-by: Tianle Huang <tianleh@amazon.com> * update function visibility and error function Signed-off-by: Tianle Huang <tianleh@amazon.com> * fix unit test failures Signed-off-by: Tianle Huang <tianleh@amazon.com> * add unit test Signed-off-by: Tianle Huang <tianleh@amazon.com> * remove lint file Signed-off-by: Tianle Huang <tianleh@amazon.com> * add more tests Signed-off-by: Tianle Huang <tianleh@amazon.com> * add unit tests for routes Signed-off-by: Tianle Huang <tianleh@amazon.com> * add remaining unit tests Signed-off-by: Tianle Huang <tianleh@amazon.com> * add enabled to this plugin Signed-off-by: Tianle Huang <tianleh@amazon.com> * update readme to mention experimental Signed-off-by: Tianle Huang <tianleh@amazon.com> * update change log Signed-off-by: Tianle Huang <tianleh@amazon.com> * dummy commit to trigger workflow rerun Signed-off-by: Tianle Huang <tianleh@amazon.com> * remove experimental Signed-off-by: Tianle Huang <tianleh@amazon.com> * add key to yml file Signed-off-by: Tianle Huang <tianleh@amazon.com> * remove i18n Signed-off-by: Tianle Huang <tianleh@amazon.com> * remove lint rc Signed-off-by: Tianle Huang <tianleh@amazon.com> * update comment style Signed-off-by: Tianle Huang <tianleh@amazon.com> * add input validation Signed-off-by: Tianle Huang <tianleh@amazon.com> * update unit tests Signed-off-by: Tianle Huang <tianleh@amazon.com> * prevent multiple registration Signed-off-by: Tianle Huang <tianleh@amazon.com> * add return types Signed-off-by: Tianle Huang <tianleh@amazon.com> * update readme wording Signed-off-by: Tianle Huang <tianleh@amazon.com> * add unit test to the plugin class about double register Signed-off-by: Tianle Huang <tianleh@amazon.com> * move related ymls Signed-off-by: Tianle Huang <tianleh@amazon.com> * move validation to a function Signed-off-by: Tianle Huang <tianleh@amazon.com> * use trimmed versions Signed-off-by: Tianle Huang <tianleh@amazon.com> * reword changelog entry Signed-off-by: Tianle Huang <tianleh@amazon.com> * readability Signed-off-by: Tianle Huang <tianleh@amazon.com> * add back yml change Signed-off-by: Tianle Huang <tianleh@amazon.com> --------- Signed-off-by: Tianle Huang <tianleh@amazon.com>
…ct#5949) * refact: move workspace specific logic to savedObjectWrapper Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: some error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: fix test error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless config in test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add CHANGELOG Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add more unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: revert test in repository.test.js Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: revert test in import_saved_objects.test.ts Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: revert test in repository.test.js Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add type Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap type error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code and add comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: integration test fail Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add missing code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Add permissions field to the mapping only if the permission control is enabled Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix test failure Signed-off-by: gaobinlong <gbinlong@amazon.com> * feat: modify unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bulk create error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bulk create error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add new config in yml file Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add new config in yml file Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update yml file Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: fix unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: do not skip migration when doing integration test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: change flag variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add test cases Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Co-authored-by: gaobinlong <gbinlong@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
wanglam
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration