Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace]Following pr for #5949 (#6012) #276

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

SuZhou-Joe
Copy link
Collaborator

@SuZhou-Joe SuZhou-Joe commented Mar 4, 2024

Description

backport official 6012 pr to workspace

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…ct#6012)

* feat: temp save

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add some comment

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.76%. Comparing base (3a4bcd5) to head (6db774e).

Additional details and impacted files
@@            Coverage Diff             @@
##           workspace     #276   +/-   ##
==========================================
  Coverage      66.76%   66.76%           
==========================================
  Files           3337     3337           
  Lines          64809    64809           
  Branches       10456    10456           
==========================================
  Hits           43268    43268           
  Misses         18953    18953           
  Partials        2588     2588           
Flag Coverage Δ
Linux_1 31.41% <100.00%> (ø)
Linux_2 55.22% <ø> (ø)
Linux_3 41.74% <ø> (ø)
Linux_4 34.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit b14060a into ruanyl:workspace Mar 5, 2024
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants