Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove useless code #280

Conversation

SuZhou-Joe
Copy link
Collaborator

@SuZhou-Joe SuZhou-Joe commented Mar 5, 2024

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.96%. Comparing base (d165b88) to head (dabd5d1).

Additional details and impacted files
@@                 Coverage Diff                  @@
##           workspace-pr-integr     #280   +/-   ##
====================================================
  Coverage                66.96%   66.96%           
====================================================
  Files                     3323     3323           
  Lines                    64208    64208           
  Branches                 10309    10309           
====================================================
  Hits                     42998    42998           
  Misses                   18687    18687           
  Partials                  2523     2523           
Flag Coverage Δ
Linux_ 66.30% <ø> (+<0.01%) ⬆️
_1 31.97% <ø> (ø)
_2 55.32% <ø> (ø)
_3 43.42% <ø> (ø)
_4 35.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 3ddbf99 into ruanyl:workspace-pr-integr Mar 6, 2024
41 of 46 checks passed
SuZhou-Joe added a commit that referenced this pull request Mar 18, 2024
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants