remove management workspace (#278) #281
Conversation
* remove management workspace * delete unnecessary code comments * delete comments # Conflicts: # src/core/public/index.ts # src/core/public/utils/index.ts # src/core/utils/constants.ts # src/plugins/workspace/public/components/workspace_creator/workspace_form.tsx # src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx # src/plugins/workspace/server/workspace_client.ts
|
@yubonluo CI failed, could you please fix the error? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## workspace-pr-integr #281 +/- ##
=======================================================
+ Coverage 66.96% 66.97% +0.01%
=======================================================
Files 3323 3321 -2
Lines 64208 64422 +214
Branches 10309 10383 +74
=======================================================
+ Hits 42998 43149 +151
- Misses 18687 18731 +44
- Partials 2523 2542 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
packages/osd-analytics/yarn.lock
Outdated
There was a problem hiding this comment.
What is this lock file used for?
There was a problem hiding this comment.
The yarn.lock is used for CI launch, I dont know why only the one yarn is lost.
There was a problem hiding this comment.
@yubonluo can you paste the error? This file should NOT be changed in this PR
There was a problem hiding this comment.
This may be an occasional issue, and I have reversed the changes to the yarn.lock file. The CI has worked properly.
* remove management workspace (#278) * remove management workspace * delete unnecessary code comments * delete comments # Conflicts: # src/core/public/index.ts # src/core/public/utils/index.ts # src/core/utils/constants.ts # src/plugins/workspace/public/components/workspace_creator/workspace_form.tsx # src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx # src/plugins/workspace/server/workspace_client.ts * update typescript version to 4.6.4 * delete useless code and add a lost yarn.lock * delete yarn.lock
Conflicts:
src/core/public/index.ts
src/core/public/utils/index.ts
src/core/utils/constants.ts
delete src/plugins/workspace/public/components/workspace_creator/workspace_form.tsx
delete src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx src/plugins/workspace/server/workspace_client.ts
Description
remove management workspace
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration