-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management #283
Conversation
This reverts commit a70ce71.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## workspace-pr-integr #283 +/- ##
=======================================================
- Coverage 66.99% 66.97% -0.02%
=======================================================
Files 3325 3321 -4
Lines 64439 64431 -8
Branches 10382 10384 +2
=======================================================
- Hits 43170 43153 -17
- Misses 18729 18737 +8
- Partials 2540 2541 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LGTM, let's wait for CI to pass. |
seems that few cases are failed. |
Seems due to the app path changes of the cypress tests in FTR |
@Hailong-am run it manually against ftr |
@ruanyl should we change the branch back to main here https://github.com/ruanyl/OpenSearch-Dashboards/blob/workspace-pr-integr/.github/workflows/cypress_workflow.yml#L31C72-L31C81 |
This reverts commit 734c890.
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
changed to |
…n management and SavedObject management as standalone app, retire dashboard management (#283) * Revert "Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management (#208)" This reverts commit 5f09f84. * Revert "feat: add unit test for mountWrapper (#223)" This reverts commit a70ce71. * Revert "fix: cypress tests checkout workspace branch (#252)" This reverts commit 734c890. * run cypress with ftr main Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
…n management and SavedObject management as standalone app, retire dashboard management (#283) * Revert "Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management (#208)" This reverts commit 5f09f84. * Revert "feat: add unit test for mountWrapper (#223)" This reverts commit a70ce71. * Revert "fix: cypress tests checkout workspace branch (#252)" This reverts commit 734c890. * run cypress with ftr main Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Description
Revert Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management #208
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration