Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management #283

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

ruanyl
Copy link
Owner

@ruanyl ruanyl commented Mar 6, 2024

Description

Revert Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management #208

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

ruanyl added 2 commits March 6, 2024 14:26
…rn management and SavedObject management as standalone app, retire dashboard management (#208)"

This reverts commit 5f09f84.
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 18.51852% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 66.97%. Comparing base (370dbc6) to head (d14fd57).

Files Patch % Lines
.../plugins/index_pattern_management/public/plugin.ts 0.00% 6 Missing ⚠️
src/plugins/advanced_settings/public/plugin.ts 0.00% 4 Missing ⚠️
...rc/plugins/data_source_management/public/plugin.ts 33.33% 3 Missing and 1 partial ⚠️
.../plugins/saved_objects_management/public/plugin.ts 40.00% 3 Missing ⚠️
...terns/index_patterns/redirect_no_index_pattern.tsx 0.00% 2 Missing ⚠️
...on/index_patterns/index_patterns/index_patterns.ts 0.00% 1 Missing ⚠️
...ugins/data/public/search/errors/painless_error.tsx 0.00% 1 Missing ⚠️
...lugins/data/server/saved_objects/index_patterns.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           workspace-pr-integr     #283      +/-   ##
=======================================================
- Coverage                66.99%   66.97%   -0.02%     
=======================================================
  Files                     3325     3321       -4     
  Lines                    64439    64431       -8     
  Branches                 10382    10384       +2     
=======================================================
- Hits                     43170    43153      -17     
- Misses                   18729    18737       +8     
- Partials                  2540     2541       +1     
Flag Coverage Δ
Linux_ 66.31% <18.51%> (-0.02%) ⬇️
_1 32.14% <0.00%> (-0.01%) ⬇️
_2 55.35% <0.00%> (ø)
_3 43.29% <11.76%> (-0.02%) ⬇️
_4 35.08% <11.11%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe
Copy link
Collaborator

LGTM, let's wait for CI to pass.

@Hailong-am
Copy link
Collaborator

seems that few cases are failed.

@ruanyl
Copy link
Owner Author

ruanyl commented Mar 7, 2024

seems that few cases are failed.

Seems due to the app path changes of the cypress tests in FTR

@ruanyl
Copy link
Owner Author

ruanyl commented Mar 7, 2024

@Hailong-am run it manually against ftr main, the test cases passed https://github.com/ruanyl/OpenSearch-Dashboards/actions/runs/8181890144/job/22372367328

@Hailong-am
Copy link
Collaborator

Hailong-am commented Mar 7, 2024

Seems due to the app path changes of the cypress tests in FTR

@ruanyl should we change the branch back to main here https://github.com/ruanyl/OpenSearch-Dashboards/blob/workspace-pr-integr/.github/workflows/cypress_workflow.yml#L31C72-L31C81

ruanyl added 2 commits March 7, 2024 14:08
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@ruanyl
Copy link
Owner Author

ruanyl commented Mar 7, 2024

changed to main, the tests passed now

@ruanyl ruanyl merged commit d43cbbc into workspace-pr-integr Mar 7, 2024
10 of 58 checks passed
SuZhou-Joe pushed a commit that referenced this pull request Mar 11, 2024
…n management and SavedObject management as standalone app, retire dashboard management (#283)

* Revert "Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management (#208)"

This reverts commit 5f09f84.

* Revert "feat: add unit test for mountWrapper (#223)"

This reverts commit a70ce71.

* Revert "fix: cypress tests checkout workspace branch (#252)"

This reverts commit 734c890.

* run cypress with ftr main

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Mar 18, 2024
…n management and SavedObject management as standalone app, retire dashboard management (#283)

* Revert "Register Advance Settings, Data Source management,Index Pattern management and SavedObject management as standalone app, retire dashboard management (#208)"

This reverts commit 5f09f84.

* Revert "feat: add unit test for mountWrapper (#223)"

This reverts commit a70ce71.

* Revert "fix: cypress tests checkout workspace branch (#252)"

This reverts commit 734c890.

* run cypress with ftr main

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants