Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport workspace-pr-integr]Add support for dynamic application configurations (#5855) #302

Conversation

SuZhou-Joe
Copy link
Collaborator

  • Add application configuration service

  • update API path name

  • implement two APIs/interfaces

  • expose get function for other plugins to use

  • update interfaces

  • implement the APIs and interfaces

  • add license and jsdoc

  • update docs

  • add more docs

  • update variable name

  • remove unnecessary dependency

  • format readme

  • use osd version

  • remove debugging info

  • update logging

  • remove lint js

  • remove logs

  • update name style

  • update

  • update function visibility and error function

  • fix unit test failures

  • add unit test

  • remove lint file

  • add more tests

  • add unit tests for routes

  • add remaining unit tests

  • add enabled to this plugin

  • update readme to mention experimental

  • update change log

  • dummy commit to trigger workflow rerun

  • remove experimental

  • add key to yml file

  • remove i18n

  • remove lint rc

  • update comment style

  • add input validation

  • update unit tests

  • prevent multiple registration

  • add return types

  • update readme wording

  • add unit test to the plugin class about double register

  • move related ymls

  • move validation to a function

  • use trimmed versions

  • reword changelog entry

  • readability

  • add back yml change


Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…t#5855)

* Add application configuration service

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* update API path name

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* implement two APIs/interfaces

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* expose get function for other plugins to use

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* update interfaces

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* implement the APIs and interfaces

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* add license and jsdoc

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* update docs

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* add more docs

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* update variable name

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* remove unnecessary dependency

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* format readme

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* use osd version

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* remove debugging info

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* update logging

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* remove lint js

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* remove logs

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* update name style

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* update

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* update function visibility and error function

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* fix unit test failures

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* add unit test

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* remove lint file

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* add more tests

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* add unit tests for routes

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* add remaining unit tests

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* add enabled to this plugin

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* update readme to mention experimental

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* update change log

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* dummy commit to trigger workflow rerun

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* remove experimental

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* add key to yml file

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* remove i18n

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* remove lint rc

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* update comment style

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* add input validation

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* update unit tests

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* prevent multiple registration

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* add return types

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* update readme wording

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* add unit test to the plugin class about double register

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* move related ymls

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* move validation to a function

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* use trimmed versions

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* reword changelog entry

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* readability

Signed-off-by: Tianle Huang <tianleh@amazon.com>

* add back yml change

Signed-off-by: Tianle Huang <tianleh@amazon.com>

---------

Signed-off-by: Tianle Huang <tianleh@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe changed the title [Backport]Add support for dynamic application configurations (#5855) [Backport workspace-pr-integr]Add support for dynamic application configurations (#5855) Mar 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 85.57692% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 67.04%. Comparing base (bb8d0ac) to head (92720b8).

Files Patch % Lines
.../plugins/application_config/server/routes/index.ts 76.47% 8 Missing ⚠️
src/plugins/application_config/server/plugin.ts 78.94% 3 Missing and 1 partial ⚠️
.../plugins/application_config/server/string_utils.ts 77.77% 1 Missing and 1 partial ⚠️
...lication_config/server/opensearch_config_client.ts 97.61% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           workspace-pr-integr     #302      +/-   ##
=======================================================
+ Coverage                67.01%   67.04%   +0.02%     
=======================================================
  Files                     3340     3344       +4     
  Lines                    64907    65011     +104     
  Branches                 10488    10496       +8     
=======================================================
+ Hits                     43499    43588      +89     
- Misses                   18833    18845      +12     
- Partials                  2575     2578       +3     
Flag Coverage Δ
Linux_ 66.39% <85.57%> (+0.03%) ⬆️
_1 32.56% <ø> (ø)
_2 55.39% <ø> (ø)
_3 43.45% <85.57%> (+0.13%) ⬆️
_4 35.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 431fcdb into ruanyl:workspace-pr-integr Mar 19, 2024
41 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants