-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add update workspace page #304
Add update workspace page #304
Conversation
Signed-off-by: gaobinlong <gbinlong@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## workspace-pr-integr #304 +/- ##
====================================================
Coverage 67.04% 67.05%
====================================================
Files 3344 3345 +1
Lines 65011 65045 +34
Branches 10496 10505 +9
====================================================
+ Hits 43588 43617 +29
- Misses 18845 18849 +4
- Partials 2578 2579 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: gaobinlong <gbinlong@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gaobinlong Shall we add unit tests when |
Sure, I'll add that. |
Signed-off-by: gaobinlong <gbinlong@amazon.com>
d66c8fc
into
ruanyl:workspace-pr-integr
Description
Add update workspace page and add some unit test code.
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration