Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update workspace page #304

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

gaobinlong
Copy link
Collaborator

@gaobinlong gaobinlong commented Mar 20, 2024

Description

Add update workspace page and add some unit test code.

Issues Resolved

Screenshot

image

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: gaobinlong <gbinlong@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 73.52941% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 67.05%. Comparing base (431fcdb) to head (8a2a5cb).

Files Patch % Lines
...components/workspace_updater/workspace_updater.tsx 77.41% 3 Missing and 4 partials ⚠️
src/plugins/workspace/public/plugin.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           workspace-pr-integr     #304   +/-   ##
====================================================
  Coverage                67.04%   67.05%           
====================================================
  Files                     3344     3345    +1     
  Lines                    65011    65045   +34     
  Branches                 10496    10505    +9     
====================================================
+ Hits                     43588    43617   +29     
- Misses                   18845    18849    +4     
- Partials                  2578     2579    +1     
Flag Coverage Δ
Linux_ 66.40% <73.52%> (+<0.01%) ⬆️
_1 32.60% <73.52%> (+0.03%) ⬆️
_2 55.39% <ø> (ø)
_3 43.46% <ø> (+<0.01%) ⬆️
_4 35.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: gaobinlong <gbinlong@amazon.com>
Copy link
Collaborator

@wanglam wanglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanglam
Copy link
Collaborator

wanglam commented Mar 20, 2024

@gaobinlong Shall we add unit tests when workpsace.update throw error?

@gaobinlong
Copy link
Collaborator Author

@gaobinlong Shall we add unit tests when workpsace.update throw error?

Sure, I'll add that.

Signed-off-by: gaobinlong <gbinlong@amazon.com>
@gaobinlong gaobinlong merged commit d66c8fc into ruanyl:workspace-pr-integr Mar 21, 2024
41 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants