Provider does not detect when AWS accounts need permission updates

[DamaniN]

Expected Behavior

Periodically RSC will add new features which require permission updates to the cross account role. RSC notifies the administrator of this via the UI. When a new plan is run via Terraform, it should detect that the required permissions for the cross account role are different than the current set. It should then update those current permissions to the new set and update RSC that the permissions are now current.

Current Behavior

Currently this Terraform provider does not detect when permissions have been changed for a snappable and suggest an update.

Steps to Reproduce

This was tested against EC2 protection. Add an account using an older version of the permissions. Then run Terraform plan once the notification that the permissions need to be updated. Terraform will indicate that no changes are needed.

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

• beta.14
• RSC dev version latest as of 02/16/2024

[johan3141592]

@DamaniN could you please provide a sample TF configuration showing this problem and clarify how "add an account using an older version of the permissions" is done?

The RSC provider should detect that the RSC required set of permissions for the enabled features has changed (through the polaris_aws_cnp_permissions data source). The RSC provider does not update the permissions, this should be done using the relevant data sources and resources from the AWS provider (e.g. aws_iam_role).

There was an issue with the RSC provider resolved earlier this week where the provider would not call back to RSC after the permissions had been updated notifying RSC about it, this would leave the cloud account in the RSC UI in a missing permissions state even though the permissions had been updated.