Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename gem and make it Rails-agnostic #13

Open
3 tasks
ivy opened this issue Nov 15, 2024 · 1 comment
Open
3 tasks

Rename gem and make it Rails-agnostic #13

ivy opened this issue Nov 15, 2024 · 1 comment

Comments

@ivy
Copy link

ivy commented Nov 15, 2024

Thoughts on renaming this gem to ruby_at_scale-redis and making it Rails-agnostic? This looks small enough that you might only have to:

  • Rename the gem
  • Create a deprecated constant for BigRails::Redis
  • Swap the ActiveSupport::Autoload dependency with Zeitwerk
@github-actions github-actions bot added the triage A new issue that needs review by the core team label Nov 15, 2024
@dpep
Copy link

dpep commented Jan 2, 2025

I like the idea of making this gem rails optional. If Rails is present, sprinkle in the Rails.application.redis.for helpers. Otherwise, the functionality can be exposed elsewhere. The change might also require us to audit the library to ensure we're not using any rails helpers, and upgrading the specs to run with/without rails installed

@tstannard tstannard removed the triage A new issue that needs review by the core team label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants