Add Rubocop to Github CI #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t as we clean things up.
freestylebit
reviewed
Oct 3, 2022
| breeds = [ 'Labrador', 'Poodle', 'German Shepherd', 'Golden Retriever', 'Pug' ] | ||
| weights = [ 'Small', 'Medium', 'Large' ] | ||
| sexs = [ 'Male', 'Female' ] | ||
| names = %w[Bella Buddy Buster Cali Charlie Max Oliver Oscar Penny Riley Shadow |
freestylebit
reviewed
Oct 3, 2022
| git_source(:github) { |repo| "https://github.com/#{repo}.git" } | ||
|
|
||
| ruby "3.0.2" | ||
| ruby '3.0.2' |
There was a problem hiding this comment.
I generally like to minimize the number of diffs when we're introducing rubocop to a repo at first. If we want to go with single quotes, we can create a PR afterwards that introduces that single rule change so that reviewing the diff is very simple.
edwinthinks
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #113
I added some Ignore rules just to get the Rubocop config file in place - we can tighten these restrictions as we work on things.
There are a number of manual changes I had to do in order to satisfy some of the rules - I wouldn't mind some eyes on those changes to make sure I didn't break anything. I'm mostly leaning on unit tests and CI here.