Convert optional keyword arg to options #2804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we go ahead with this or wait for delayed_job to officially support ruby 3? seem like it can be a while. |
Fixes: /usr/local/bundle/gems/delayed_job-4.1.9/lib/delayed/performable_method.rb:26: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call /app/lib/fastly.rb:10: warning: The called method `purge' is defined here The warning is being raised because delayed_job does not support ruby 3
sonalkr132
force-pushed
the
purge-opt-args
branch
from
de59f15 to
1dccee2
Compare
|
I'm ok to move with this as is in this PR. Sadly, DJ seems not very well maintained. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
/usr/local/bundle/gems/delayed_job-4.1.9/lib/delayed/performable_method.rb:26: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/app/lib/fastly.rb:10: warning: The called method `purge' is defined here
The warning is being raised because delayed_job does not support ruby 3. collectiveidea/delayed_job#1134