From 09009d77698578e274758de8ad9ee8c93236db69 Mon Sep 17 00:00:00 2001
From: Everett Hildenbrandt <everett.hildenbrandt@gmail.com>
Date: Wed, 28 Aug 2024 15:02:07 -0600
Subject: [PATCH] Cleanup CI steps (#4611)

This is some changes I noticed we can make to CI:

- We remove the job "post performance numbers", which hasn't worked for
at least 6 months:
https://github.com/runtimeverification/k/actions/runs/8081624497
- Update some actions that were giving deprecated Node.js warnings.
---
 .github/workflows/develop.yml | 56 -----------------------------------
 .github/workflows/release.yml |  2 +-
 2 files changed, 1 insertion(+), 57 deletions(-)

diff --git a/.github/workflows/develop.yml b/.github/workflows/develop.yml
index c3623290323..745a9c7ade9 100644
--- a/.github/workflows/develop.yml
+++ b/.github/workflows/develop.yml
@@ -37,59 +37,3 @@ jobs:
           if git add --update && git commit --no-edit --allow-empty --message "Set Version: $(cat package/version)"; then
             git push origin master
           fi
-
-  post-performance-tests:
-    name: 'Performance Tests'
-    runs-on: [self-hosted, linux, normal]
-    continue-on-error: true
-    steps:
-      - uses: actions/checkout@v4
-      - name: 'Set up Docker Test Image'
-        env:
-          BASE_OS: ubuntu
-          BASE_DISTRO: jammy
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          BENCHER_API_TOKEN: ${{ secrets.BENCHER_API_TOKEN }}
-          BENCHER_PROJECT: k-framework
-          BENCHER_ADAPTER: json
-        run: |
-          set -euxo pipefail
-          workspace=$(pwd)
-          docker run --name "k-posting-profiling-tests-${GITHUB_SHA}" \
-            --rm -it --detach                                         \
-            -e BENCHER_API_TOKEN="$BENCHER_API_TOKEN"                 \
-            -e BENCHER_PROJECT="$BENCHER_PROJECT"                     \
-            -e BENCHER_ADAPTER="$BENCHER_ADAPTER"                     \
-            -e GITHUB_HEAD_REF="$GITHUB_HEAD_REF"                     \
-            -e GITHUB_BASE_REF="$GITHUB_BASE_REF"                     \
-            -e GITHUB_TOKEN="$GITHUB_TOKEN"                           \
-            -e GITHUB_ACTIONS=true                                    \
-            -e GITHUB_EVENT_NAME="$GITHUB_EVENT_NAME"                 \
-            -e GITHUB_EVENT_PATH="$GITHUB_EVENT_PATH"                 \
-            -e GITHUB_REPOSITORY="$GITHUB_REPOSITORY"                 \
-            -e GITHUB_REF="$GITHUB_REF"                               \
-            -e GITHUB_SHA="$GITHUB_SHA"                               \
-            --workdir /opt/workspace                                  \
-            -v "${workspace}:/opt/workspace"                          \
-            -v "${GITHUB_EVENT_PATH}:${GITHUB_EVENT_PATH}"            \
-            "${BASE_OS}:${BASE_DISTRO}"
-      - name: 'Setting up dependencies'
-        run: |
-          set -euxo pipefail
-          docker exec -t "k-posting-profiling-tests-${GITHUB_SHA}" /bin/bash -c './k-distribution/tests/profiling/setup_profiling.sh SKIP_K_BUILD'
-      - name: 'Getting Performance Tests Results'
-        run: |
-          set -euxo pipefail
-          docker exec -t "k-posting-profiling-tests-${GITHUB_SHA}" /bin/bash -c './k-distribution/tests/profiling/post_results_to_develop.py "${GITHUB_SHA}"'
-      - name: 'Posting Performance Tests Results'
-        run: |
-          set -euxo pipefail
-          docker exec -t "k-posting-profiling-tests-${GITHUB_SHA}" /bin/bash -c 'bencher run            \
-            --if-branch "develop" --else-if-branch "master"                    \
-            --file .profiling-results.json --err --ci-only-on-alert            \
-            --github-actions "${GITHUB_TOKEN}" "echo Exporting report"'
-      - name: 'Tear down Docker'
-        if: always()
-        run: |
-          docker stop --time=0 "k-posting-profiling-tests-${GITHUB_SHA}"
-          docker container rm --force "k-posting-profiling-tests-${GITHUB_SHA}" || true
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 43aa7207fb2..3ed90fe2f00 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -76,7 +76,7 @@ jobs:
           name: k-framework-binary
 
       - name: 'Publish K to k-framework-binary cache'
-        uses: workflow/nix-shell-action@v3.3.0
+        uses: workflow/nix-shell-action@v3.3.2
         env:
           CACHIX_AUTH_TOKEN: '${{ secrets.CACHIX_PRIVATE_KFB_TOKEN }}'
           GC_DONT_GC: '1'