Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider decoupling this crate from rav1e #165

Open
FreezyLemon opened this issue Dec 28, 2023 · 1 comment
Open

Consider decoupling this crate from rav1e #165

FreezyLemon opened this issue Dec 28, 2023 · 1 comment

Comments

@FreezyLemon
Copy link
Contributor

The current dependency on rav1e feels a bit awkward. I think it would make more sense if this crate encapsulated the actual scenechange functionality and allowed rav1e to just pull it in, similar to v_frame.

This seems more complicated than with v_frame because some parts use rav1e internals, but I don't think it's impossible.

@shssoichiro
Copy link
Contributor

I've wanted to do that, and have rav1e depend on this instead. It's hard to find a clean way to do it, and the biggest issue is the fact that the parts of rav1e that this uses are also used in other parts of rav1e, e.g. the intra and inter cost estimations are also used during rav1e's encoding process for block type decisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants