Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enough test coverage for the resampler #104

Open
lu-zero opened this issue May 7, 2022 · 3 comments
Open

Add enough test coverage for the resampler #104

lu-zero opened this issue May 7, 2022 · 3 comments

Comments

@lu-zero
Copy link
Member

lu-zero commented May 7, 2022

Currently the code is not properly tested.

@xnorpx
Copy link

xnorpx commented Jun 23, 2022

@lu-zero what is needed to ship 2.0? (I can help add test etc dependent what's blocking)

@lu-zero
Copy link
Member Author

lu-zero commented Jun 24, 2022

We need good test to make sure multichannel resampling is working, the current code for the stand-alone reworked resampler is competely bogus in that regard, I planned to rewrite it, but that requires tests first :)

@xnorpx
Copy link

xnorpx commented Jun 24, 2022

ok, will take a look, written integration test when consuming the crate so maybe I can port some of those down. depending on how much using 2 one-channel resampler is iching :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants