Refactor chacha20poly1305 module #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyonson
force-pushed
the
chore/document-poly1305
branch
from
fd634d0 to
b85ca3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went down a few rabbit holes here, so this PR is very dense.
Updated the poly1305 implementation to be a little more robust and match the RFC spec. Before we were depending on the ChaCha20Poly1305 AEAD which just so happen to align on 16 bytes. Now the poly1305 implementation handles the
0x01byte marker correctly at the end of the message and uses a "leftovers" array so that theaddandtaginterface hasn't changed.Dropped the third party chacha20poly1305 deps we were using for testing and replaced the tests with the one from the RFC. Probably can add some more here.
Moved the ChaCha20 and Poly1305 modules into the ChaCha20Poly1305 module since we are kinda hard coding some of the aspects to the ChaCha20Poly1305 standard.