Improve cancellation safety by switching read_exacts to reads #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyonson
force-pushed
the
cancellation-safety
branch
from
facd501 to
a3f16bb
Compare
|
ACK a3f16bb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying
read_exactimplementations are not cancellation safe themselves, so have to get rid of them and hold onto state manually to ensure no dropped bytes.Pretty straight forward code change, but I had to do a little deep dive to wrap my head around what was going on: https://blog.yonson.dev/log/2024-10-vol1/
Closes #75