Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retry auto approves previously unapproved pr? #159

Open
matthiaskrgr opened this issue Nov 7, 2021 · 0 comments
Open

retry auto approves previously unapproved pr? #159

matthiaskrgr opened this issue Nov 7, 2021 · 0 comments

Comments

@matthiaskrgr
Copy link
Member

Just saw someone first trying to enable a perf-run on their pr, but it failed due to CI failing.
They did a @bors retry which did not retry the perf run but instead marked the pr as waiting-on-bors (and as approved I assume).

Maybe bors retry should not work or at least warn when run on a pr that has never been approved before?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matthiaskrgr