Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to caller location #62

Open
celinval opened this issue Feb 6, 2024 · 0 comments
Open

Add support to caller location #62

celinval opened this issue Feb 6, 2024 · 0 comments
Assignees

Comments

@celinval
Copy link
Contributor

celinval commented Feb 6, 2024

The ABI of functions with #[track_caller] include the caller location as an argument, however, we don't have any mechanism to generate the expected Location. We should add support for it.

For more details, see https://rustc-dev-guide.rust-lang.org/backend/implicit-caller-location.html.

celinval added a commit to celinval/kani-dev that referenced this issue Feb 6, 2024
Use FnAbi instead of function signature when generating code for
function types. Properly check the `PassMode::Ignore`.
For foreign functions, instead of ignoring the declaration type, cast
the arguments and return value.

For now, we also ignore the caller location, since we don't currently
support tracking caller location. This change makes it easier for us to
do so. We might want to wait for this issue to get fixed so we can
easily add support using stable APIs:

rust-lang/project-stable-mir#62
celinval added a commit to model-checking/kani that referenced this issue Feb 6, 2024
Use FnAbi instead of function signature when generating code for
function types. Properly check the `PassMode::Ignore`. For foreign
functions, instead of ignoring the declaration type, cast the arguments
and return value.

For now, we also ignore the caller location, since we don't currently
support tracking caller location. This change makes it easier for us to
do so. We might want to wait for this issue to get fixed so we can
easily add support using stable APIs:
rust-lang/project-stable-mir#62

Resolves #2260
Resolves #2312
Resolves #1365
Resolves #1350
@celinval celinval self-assigned this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant