Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APIs for coroutines equivalent to those for closures #70

Open
momvart opened this issue Mar 16, 2024 · 2 comments
Open

Add APIs for coroutines equivalent to those for closures #70

momvart opened this issue Mar 16, 2024 · 2 comments

Comments

@momvart
Copy link

momvart commented Mar 16, 2024

Coroutines and closures have quite similar type structures. It makes sense to provide similar APIs for coroutines as those that exist for closures, like:

  • Context::closure_sig
  • Context::resolve_closure
  • Coverage in Context::fn_sig
@oli-obk
Copy link
Contributor

oli-obk commented Mar 18, 2024

I don't know if we'll be able to promise that we'll be able to refactor all of these APIs in the background without breaking the SMIR API. They change really rarely, so maybe that's not an issue

@momvart
Copy link
Author

momvart commented Mar 18, 2024

I don't know if we'll be able to promise that we'll be able to refactor all of these APIs in the background without breaking the SMIR API.

True. Before anything, it's "stable" MIR.

They change really rarely, so maybe that's not an issue

Yeah. Also, we currently have CoroutineDef, and some APIs for it like getting the signature seem to be quite static, even if the background changes in Context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants