Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code documentation #72

Open
celinval opened this issue Mar 28, 2024 · 5 comments
Open

Improve code documentation #72

celinval opened this issue Mar 28, 2024 · 5 comments

Comments

@celinval
Copy link
Contributor

StableMIR definitions could use some comments.

I don't know what is the best way to move forward to avoid duplicating rustc's documentation plus adding more comments.

@celinval celinval changed the title Improve documentation Improve code documentation Apr 23, 2024
@momvart
Copy link

momvart commented Apr 26, 2024

I don't know what is the best way to move forward to avoid duplicating rustc's documentation

We can add "See also [xyz](item in rustc's mir)" but I'm not sure if any reference to the compiler should be avoided or not.

@celinval
Copy link
Contributor Author

Would that work with crates.io documentation? I tried to find a way to "inline" a linked documentation, but no luck.

@momvart
Copy link

momvart commented Apr 26, 2024

I tried to find a way to "inline" a linked documentation, but no luck.

No experience unfortunately.

Although I'm not sure what you exactly mean by inlining, is it necessary to inline them? By default, they appear as links to the official online rustc's documents.

@celinval
Copy link
Contributor Author

I mean, this is definitely an improvement to what we have today, but it won't work once we publish the stable mir crate in crates.io.

@celinval
Copy link
Contributor Author

The link will likely be broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants