-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could we generate Borrow
implementations to super classes?
#3794
Comments
I unfortunately don't know the historical context here, but I don't really see a reason why
I believe this isn't relevant. |
Summary
Borrow
acts similarly toAsRef
, with a slight difference being that the former also requiresPartialEq
,Eq
andHash
to work the same for the borrowed type.This seems to be upheld by JS classes -> superclasses, and as such I'm wondering why this trait isn't implemented for those?
Is it just because most of them don't implement
Hash
? If that were to change, would it make sense to implementBorrow
?Additional Details
I'm taking inspiration from this crate for a few design decisions for
objc2
, and would like to know your thoughts on this.The text was updated successfully, but these errors were encountered: