Set default-features = false for image dependency
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll admit my ignorance here, is the issue over-inclusion of dependencies? I'll review the PR this weekend, I should have time then, I'm trying to finish up some ports from the C++ version. |
|
Yep, that's pretty much it. Imagine I'm writing an application that'll only ever need to decode from PNGs. Because rxing depends on image's default features, there's no way for me to disable all the other image formats. |
|
I appreciate the explanation! Given that, this change makes sense to me. I should have time to review this weekend. |
hschimke
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once enabled, there's no way to disable a cargo feature, so as a library, rxing probably shouldn't enable all the formats supported by the image crate.
This PR conditionally disables tests that depend on the
imageorimage-formatsfeatures, introduces theimage-formatsfeature and enables it by default, and adds a test step to the GitHub Actions workflow to test the crate with default features disabled.