[just_audio_background] Fix: Shuffle order out of sync after inserting/removing item from ConcatenatingAudioSource #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dioSource due to shuffleOrder not being updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
insert()orremoveAt()on aConcatenatingAudioSource, a newshuffleOrderis passed with the request but it is not updated in just_audio_background's correspondingConcatenatingAudioSourceMessage. This results in the shuffle order being out of sync, which can cause issues such as an out of range exception in the case ofremoveAt().This PR also includes a change to just_audio which I found was necessary to resolve the issue I was experiencing with
removeAt(), though I'm not sure why it seemed to make a difference.