Fix bug 871, 'IcMetadata.Info can be stale' #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…java print statements to onMetadata(). So fard, with the default media url, we get icyInfo.title (i.e. song) and url (i.e. artwork url).
…_radio to add the stations that highlight the problem. Also added a README file.
…e of C_LENGTH_UNSET doesn't generate a call to onMetadata(), in onTracksChanged() simply set the icyInfo instance variable to null to clear the stale data.
…he result should be a pristine, up-to-date copy of JustAudio with a couple of lines of changes/fixes.
|
@ryanheise any plans to merge this? |
|
I had plans to change the API altogether to be less tied to ICY metadata, however I think it's reasonable to probably merge this now. But have you tested it yourself and found it to work well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android platform only: When a new track is selected that has a Metadata header with a metadataInterval of -1 (i.e. C.LENGTH_UNSET), onMetadata() is never called; thus, the stale metadata info from the last track is not cleared. This fix clears the metadata info under this condition.