Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the names for the colored coverage elements #302

Open
ryanluker opened this issue Apr 11, 2021 · 0 comments
Open

Rework the names for the colored coverage elements #302

ryanluker opened this issue Apr 11, 2021 · 0 comments

Comments

@ryanluker
Copy link
Owner

ryanluker commented Apr 11, 2021

Reference

#239 (comment)

Problem

The old names for the coverage elements (highlights) is quite confusing now that we have gutter coverage elements as well as line and map based ones. We can use the example naming by @DevilXD as a starting point for switching to something more sensical.

Work

  1. Slightly adjust the settings names to make more sense regarding their visual nature.
  2. Figure out if this change should be in the next minor release or next major (changing the setting name will probably mean a breaking change unless we deprecate the old value and use it as the default for folks that have set it)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant