-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caskaydia Cove introduces ligature issue not in Cascadia Code #1291
Comments
The problem with Installing that thing now, hold tight. |
@phjordan Btw, please share a picture of your You see I have no Cascadia Code installed. I unpacked the Caskaydia zip file, select all, right click, install (for user) (is how I installed the fonts). |
Windows is so easy, everything works out of the box! |
Thanks for the input! There are indeed size-limits where the font switches rendering, I will check that. Edit: Ah, report was for Win 11 🤦♀️ |
Ah, I have another hunch... I fear that it might be the hints 🙄 |
This is the reason why I hate the bundling of Windows Terminal with Cascadia Cove, because they bundle the VF and one has to go through a lengthy operation to remove that if you want the otf or pure ttf ones instead. The |
Also reproducible on windows 10 👍🏼 |
@harshv1741 This is no ligature Issue. Please check out |
[why] Some Caskaydia Cove glyphs that are used in ligatures (to create endless arrows for example) show uneven line thickness on some platforms. The reason is the not-matching hinting of glyphs that are places next to each other and so minuscule differences are quite visible. Note that the 'original' hinting is generated by VTT on the static Cascadia Code instances, which upstream just have ttfautohint hints that are different from the hints in the variable fonts and people complained that the look is different. [how] Add a new field to the config.json file that holds regexes of glyph names for glyphs that should be re-hinted by fontforge on patching time. In principle we could also implement that as an additional pre-step that needs to be manually done after running VTT on the static font files. I'm not sure which is better. Note that fontforge generates a lot of debug output because the hinting is not ideal - the global tables are kept and probably less compatible to fontforge's own hinting... But the results are good. Fixes: #1291 Fixes: #1609 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
I would need someone who can test the potential fix, good would be a thorough test like @phjordan with all the arrows. |
[why] Some Caskaydia Cove glyphs that are used in ligatures (to create endless arrows for example) show uneven line thickness on some platforms. The reason is the not-matching hinting of glyphs that are places next to each other and so minuscule differences are quite visible. Note that the 'original' hinting is generated by VTT on the static Cascadia Code instances, which upstream just have ttfautohint hints that are different from the hints in the variable fonts and people complained that the look is different. [how] Add a new field to the config.json file that holds regexes of glyph names for glyphs that should be re-hinted by fontforge on patching time. In principle we could also implement that as an additional pre-step that needs to be manually done after running VTT on the static font files. I'm not sure which is better. Note that fontforge generates a lot of debug output because the hinting is not ideal - the global tables are kept and probably less compatible to fontforge's own hinting... But the results are good. Fixes: #1291 Fixes: #1609 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] Some Caskaydia Cove glyphs that are used in ligatures (to create endless arrows for example) show uneven line thickness on some platforms. The reason is the not-matching hinting of glyphs that are places next to each other and so minuscule differences are quite visible. Note that the 'original' hinting is generated by VTT on the static Cascadia Code instances, which upstream just have ttfautohint hints that are different from the hints in the variable fonts and people complained that the look is different. [how] Add a new field to the config.cfg file that holds regexes of glyph names for glyphs that should be re-hinted by fontforge on patching time. In principle we could also implement that as an additional pre-step that needs to be manually done after running VTT on the static font files. I'm not sure which is better. Note that fontforge generates a lot of debug output because the hinting is not ideal - the global tables are kept and probably less compatible to fontforge's own hinting... But the results are good. Fixes: #1291 Fixes: #1609 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
It would be great if someone who sees the arrows problem can check this font: CaskaydiaCove_arrows.zip Version (Probably you need to uninstall the old Caskaydia first, then reboot, then install the font given in this comment.) Without reports it is hard to see if this will fix it or not... Help needed. |
Thanks for the update, i'll give it a try as soon as I can! |
Hmm, this is maybe also a hinting problem, this is most visible at 12 pt / 96 dpi. The advance width is 9.4 pixel, and so the last pixel is only filled less than half, so it is rendered half-grey. The situation is comparable with FiraCode unpatched: Just here other sizes show that same problem. Are you sure Cascadia Code unpatched does not have the same problem at some sizes? Maybe you can try. I can check, but I believe this is a principle problem that can not be solved without 'massive' manual intervention. Affected are a high number of glyphs (the |
Thank you for testing all that stuff! |
@allcontributors please add @FrancescoLuzzi for bug |
I've put up a pull request to add @FrancescoLuzzi! 🎉 |
[why] Some Caskaydia Cove glyphs that are used in ligatures (to create endless arrows for example) show uneven line thickness on some platforms. The reason is the not-matching hinting of glyphs that are places next to each other and so minuscule differences are quite visible. Note that the 'original' hinting is generated by VTT on the static Cascadia Code instances, which upstream just have ttfautohint hints that are different from the hints in the variable fonts and people complained that the look is different. [how] Add a new field to the config.cfg file that holds regexes of glyph names for glyphs that should be re-hinted by fontforge on patching time. In principle we could also implement that as an additional pre-step that needs to be manually done after running VTT on the static font files. I'm not sure which is better. Note that fontforge generates a lot of debug output because the hinting is not ideal - the global tables are kept and probably less compatible to fontforge's own hinting... But the results are good. Fixes: #1291 Fixes: #1609 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Oh! == is don't work, or my computer have problem? |
Hi, first, thank you for this nerd font, I've been using for four years now. I'm experiencing the same ligature 'tearing' issue as @Phoenix- (screen capture below) In the --> ligature the 'tearing' is barely noticiable In the ==> ligature, the 'tearing' is much more noticiable These are the fonts shown in the screen capture (screen capture below) My versions
|
The problem is the hinting.
The possibilities here are:
Then I obviously did something here with commit b2cf801 That has been merged mid April 2024, just after the So probably your problems will (mostly) go away after the next release, which is |
Thanks for the explanation and for your work. Great fonts :) |
Testing in Windows Terminal - font size 12, Windows 11, NF v3.0.2
I would expect the ligature for
=>
to be the same and without visual artifacts.Cascadia Code:
CaskaydiaCove Nerd Font Mono:
🗹 Requirements
The text was updated successfully, but these errors were encountered: