Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass energy parameter file to locarna_rnafold_pp #20

Open
mmiladi opened this issue Mar 2, 2017 · 3 comments
Open

Pass energy parameter file to locarna_rnafold_pp #20

mmiladi opened this issue Mar 2, 2017 · 3 comments

Comments

@mmiladi
Copy link
Collaborator

mmiladi commented Mar 2, 2017

Hi @s-will,

What do you think of having optional parameter to pass an energy param file to locarna_rnafold_pp?
--paramFile=paramfile
I'll start implementing that, first wanted to know your opinion and be sure it is not already integrated inside locarna :)

Best,
M

@s-will
Copy link
Owner

s-will commented Mar 2, 2017

Alignment with different parameter files is currently supported only by mlocarna (--rnafold-parameter).
Currently, mlocarna does call RNAfold instead of locarna_rnafold_pp, if this option is given.
Of course, it would be interesting to migrate this feature into the Locarna lib and rnafold_pp, since then we could use this even for calls to locarna/locarna_p/sparse (without the need for mlocarna).

btw, there are also some other features of RNAfold that would be cool to have :).

If you want to add paramFile (and maybe other such features), the additional parameters should be passed to RnaEnsemble via PFoldParams. In RnaEnsembleImpl, the two folding methods (regular and alifold) that generate the McCaskill matrices should be extended: compute_McCaskill_matrices and compute_McCaskill_alifold_matrices. For SPARSE, one also must make sure that extensions do not break the inloop probs computation.

@mmiladi
Copy link
Collaborator Author

mmiladi commented Mar 3, 2017

Thanks much for the detailed info. I thought you use locarna_rnafold_pp inside mlocarna. We wanted to check it for the Bralibase benchmarking, so for the moment --rnafold-parameter was fine.

However I would be happy to contribute and extend locarna_rnafold_pp, maybe we could think of useful options that could be added there and I start working on it.

@s-will
Copy link
Owner

s-will commented Mar 3, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants