Is it intended behavior for cargo-make not to use environment variable defined in the executing environment?

[wmmc88]

You can define an environment variable for RUSTFLAGS via $env:RUSTFLAGS="-D warnings" in pwsh or export RUSTFLAGS="-D warnings" in bash. Any cargo build commands you run after it will use that value for rust flags.

When you do cargo make build, the environment which cargo-make invokes cargo build does not inherit the environment in which cargo make was executed. Is this intentional behavior? I find its sort of weird that it creates this completely clean environment instead of using the original execution environment as a base.

[sagiegurari]

its possible that rustflags is defined in the internal makefile, maybe stable.toml and therefore overwirtes external value.
if so, it can be fixed by overriding it in custom make file by setting it to use the already defined env value

[sagiegurari]

i see i dknt overwrite it.... i wonder if its same cargo issue you fixed a while back

[wmmc88]

Thanks for reminding me about #1059 (comment). I reread the threads, and it looks like the original recommendation from rustup was to clear CARGO, RUSTC, and RUSTDOC, but in the original fix, you added code to reset RUSTC, RUSTDOC and RUSTFLAGS. I think that to fix this, RUSTFLAGS needs to be removed from the list of vars to clear (as it shouldn't have been there in the first place).

[sagiegurari]

cool. I'll fix it

[sagiegurari]

i'm releasing a fix for this now. will be released in an hour or less.