Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix comics] Format change at comicskingdom.com #46

Open
FrankBS opened this issue Mar 25, 2024 · 1 comment
Open

[Fix comics] Format change at comicskingdom.com #46

FrankBS opened this issue Mar 25, 2024 · 1 comment
Labels
fix comic Fix a broken strip extraction help wanted Extra attention is needed

Comments

@FrankBS
Copy link

FrankBS commented Mar 25, 2024

Daily Comics VERSION (Daily Comics → [Top pulley] About): 1.9.95

NECESSARY DATA

  • Name of the strips
    Hagar the horrible
    Beetle Bailey
    Living with Hipstergirl and Gamergirl
  • Document, which source code page allows for extracting a URL to a single image of the newest, published strip by a RegEx (see next bullet point). This page may be identical to the home-page of the strip.
    https://comicskingdom.com/hagar-the-horrible
    https://comicskingdom.com/beetle-bailey-1
    https://www.jagodibuja.com/webcomic-living-with-hipstergirl-and-gamegirl-english
  • An idea for a RegEx (regular expression) to do so, containing a sub-expression which exactly matches the image path, either as an full URL or a path relative to the extraction page URL in the prior bullet point.
    no Idea
    no Idea
    no Idea
  • If such a single RegEx is not feasible, please design a JavaScript code snippet, which extracts the URL to the image of the current comic strip from the document retrieved via the URL provided in the second bullet point of this section "NECESSARY DATA".
    <JavaScript code>
    

ADDITIONAL INFORMATION

<Please consider thoroughly which other pieces of information may be relevant.>
Looks like the pages format has changed. I am not able to find a new RegEx. Can someone help, please?

@FrankBS FrankBS added the fix comic Fix a broken strip extraction label Mar 25, 2024
@Olf0 Olf0 changed the title [Fix strips] HÄGAR the horrible, beetle bailey, LIVING WITH... [please] [Fix strips] Hägar the horrible, beetle bailey, Living with Hipstergirl and Gamergirl Mar 25, 2024
@Olf0 Olf0 changed the title [Fix strips] Hägar the horrible, beetle bailey, Living with Hipstergirl and Gamergirl [Fix strips] Hagar the horrible, Beetle Bailey, Living with Hipstergirl and Gamergirl Mar 25, 2024
@Olf0 Olf0 changed the title [Fix strips] Hagar the horrible, Beetle Bailey, Living with Hipstergirl and Gamergirl [Fix strips] Format change at www.comicskingdom.com Mar 27, 2024
@Olf0
Copy link

Olf0 commented Mar 28, 2024

  1. "Living with Hipstergirl and Gamergirl" is completely unrelated to comicskingdom.com's format change! See PR Delete "Living with hipstergirl and gamergirl" … #47 for details.

  2. "Dennis The Menace" is also affected by comicskingdom.com's format change, as the quick GitHub search for repo:sailfishos-applications/daily-comics comicskingdom.com reveals.

  3. You will not "find" an appropriate RegEx for two reasons:

    • The extraction rules have to be researched and a corresponding RegEx or JavaScript snippet developed to implement each extraction rule.
    • comicskingdom.com's format change results in requiring a small piece of JavaScript, because first one has to extract the link to the recent comic's page from the "Latest Comics" box or the small "READ" on base page, then download the content of this recent comic's page and extract the URL of the topmost comic strip beneath the "SEE LATEST" oval.
      See C. Cassandra needs to be updated tardypad/sailfishos-daily-comics#89 (comment) as an example for this algorithm.
  4. Because the strip extraction for these three comics hosted at comicskingdom.com does not work at the moment, I deleted their plug-ins by PR Delete broken plug-ins by comicskingdom.com's format change #49; they can be resurrected at any time, all prior information is still available in the history of this git repository.

  5. This is Free, Libre, Open Source Software (FLOSS) and as usual based on open standards: Every aspect of implementing or fixing a plug-in for Daily Comics is publicly documented. By stating "no Idea", I can only assume that you have not performed much research.

    As I do not have time for this, because I am not interested in these comics and have many other tasks in my backlog, you either take your time to research this (and maybe educate yourself for being able to do so) or wait until somebody else does.

@Olf0 Olf0 changed the title [Fix strips] Format change at www.comicskingdom.com [Fix comics] Format change at www.comicskingdom.com Mar 28, 2024
@Olf0 Olf0 changed the title [Fix comics] Format change at www.comicskingdom.com [Fix comics] Format change at comicskingdom.com Mar 28, 2024
Olf0 added a commit that referenced this issue Mar 28, 2024
Olf0 added a commit that referenced this issue Mar 28, 2024
Strip extraction is broken, see issue #46.
Olf0 added a commit that referenced this issue Mar 28, 2024
Strip extraction is broken, see issue #46.
Olf0 added a commit that referenced this issue Mar 28, 2024
* Delete plugins/beetlebailey directory
  Strip extraction is broken, see issue #46.

* Delete plugins/dennisthemenace directory
  Strip extraction is broken, see issue #46.

* Delete plugins/hagarthehorrible directory
  Strip extraction is broken, see issue #46.
@Olf0 Olf0 added the help wanted Extra attention is needed label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix comic Fix a broken strip extraction help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants