Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile native sources for arm64 #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KevinBaragonaIJKCO
Copy link

This makes it work on arm64 devices. Fixes #105 for me...

This makes it work on arm64 devices. Fixes saki4510t#105 for me...
@saki4510t
Copy link
Owner

Sorry for my answer delay and thank you for providing pull request.

Your issue came from that you mixed libraries that have 64 bits binary with the libraries that have no 64 bits binary.
Please check WiKi How to exclude native binaries for specific architecture(s)

If you really need 64 bits binaries, I feel it will be better to use APP_ABI := all because your pull request can't solve similar issue for x86_64 & mips64 architectures.
APP_ABI := all generates libraries for all architectures supported by current NDK.
So could you change to?

@saki4510t
Copy link
Owner

As I wrote on How to exclude native binaries for specific architecture(s), I don't want to build this repository for 64 bit architectures as default setting.

@muojp
Copy link

muojp commented Sep 26, 2018

I read through https://github.com/saki4510t/UVCCamera/wiki/How-to-exclude-native-binaries-for-specific-architecture(s) doc. Unfortunately, time passed and situation changed due to Google's new policy announced in December 2017.

https://android-developers.googleblog.com/2017/12/improving-app-security-and-performance.html

64-bit binary will be required for new and updated apps. We need to be ready against the new policy before August 2019, so it would be a suitable time for reconsideration and polishing.

@muojp
Copy link

muojp commented Sep 26, 2018

I composed a new pull-req for this: #412

@saki4510t could you please review the pull-req?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants