fix search button

saleem-hadad · May 15, 2019 · 8c3ced6 · 8c3ced6
1 parent a63c899
commit 8c3ced6
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/publishable/assets/js/app.js b/publishable/assets/js/app.js
diff --git a/resources/js/components/AlgoliaSearchBox.vue b/resources/js/components/AlgoliaSearchBox.vue
@@ -15,7 +15,9 @@ export default {
   props: ["algoliaKey", "algoliaIndex", "version"],
   methods: {
     close() {
-      this.$emit("close");
+      if(! ['search-button', 'search-button-icon'].includes(targetId)) {
+        this.$emit("close");
+      }
     }
   },
   mounted() {

diff --git a/resources/js/components/InternalSearchBox.vue b/resources/js/components/InternalSearchBox.vue
@@ -63,8 +63,11 @@ export default {
     };
   },
   methods: {
-    close() {
-      this.$emit("close");
+    close(e) {
+      let targetId = e.target.id;
+      if(! ['search-button', 'search-button-icon'].includes(targetId)) {
+        this.$emit("close");
+      }
     },
     navigateToHeading(page, heading) {
       window.location =  this.versionUrl + page.path + "#" + this.slugify(heading);

diff --git a/resources/views/partials/nav.blade.php b/resources/views/partials/nav.blade.php
@@ -23,7 +23,7 @@
                     :type="searchBox ? 'primary' : 'link'"
                     @click="searchBox = ! searchBox"
                     class="px-4">
-                    <i class="fas fa-search"></i>
+                    <i class="fas fa-search" id="search-button-icon"></i>
                 </larecipe-button>
             @endif