Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit local dev setup with Docker #157

Closed
1 of 4 tasks
lkostrowski opened this issue Jul 26, 2022 · 9 comments
Closed
1 of 4 tasks

Revisit local dev setup with Docker #157

lkostrowski opened this issue Jul 26, 2022 · 9 comments
Assignees
Labels
discussion documentation Improvements or additions to documentation

Comments

@lkostrowski
Copy link
Member

lkostrowski commented Jul 26, 2022

The current saleor-platform setup seems not to work correctly.

We expect a 1-command setup of the container with Saleor core and it's dependencies.

The main target as discussed with @mirekm is a seamless setup for frontenders, who want to encapsulate Python, DB, and another core-related tooling inside containers.

One solution is to maintain a set of Dockerfiles with each tool (Dashboard, Checkout, Core...) and one or more docker-compose configs to run entire ecosystem

  • Consult other issues and @peelar work
  • Introduce temporary fix to Docker setup
  • Consider proposal by @zaiste
  • Strategic proposal / RFC on holistic dev experience of local development, cc @peelar
@lkostrowski lkostrowski self-assigned this Jul 26, 2022
@lkostrowski lkostrowski added documentation Improvements or additions to documentation discussion labels Jul 26, 2022
@lkostrowski
Copy link
Member Author

Related saleor/saleor#10104

@lkostrowski
Copy link
Member Author

Related saleor/saleor#9764

@lkostrowski
Copy link
Member Author

Related #154

@lkostrowski
Copy link
Member Author

@lkostrowski
Copy link
Member Author

Related #30

@peelar
Copy link
Member

peelar commented Jul 27, 2022

To give you some context, here is my experience with saleor-platform:

  1. I begin the process of learning Saleor by going to the documentation
  2. Progressing through the articles, I arrive at the Installation article that lists the commands to clone the saleor-platform repository:
git clone https://github.com/saleor/saleor-platform.git --recursive --jobs 3
cd saleor-platform
docker-compose build
  1. I run all the commands, and everything is working. The only thing about that experience that can be improved is the fact that I had to run some scripts manually to apply migrations and populate the database, but that's a minor inconvenience.
  2. So, saleor-platform is running, but I don't really know what to do next.

"If this is the way to run Saleor locally, then I should be able to develop and deploy it" - I thought.

However, the first words in the README of saleor-platform are the following:

Keep in mind this repository is for local development only and is not meant to be deployed on any production environment!

Given that saleor-platform may be the beginning of people's journey with Saleor, seeing "this is not meant to be deployed" with no forwarding to some other resources on deployment, is a bit like walking into a dead-end. In my opinion, there is room for improvement on how do we guide the user in that case.

The part that says "it is for local development" could use some clarification as well. If you wanted to host your own version of Saleor, you would have to fork it. So that means the purpose of saleor-platform is mostly educational: to learn the platform and its parts. If we are in agreement about this, let's think about how to communicate that better.

@lkostrowski
Copy link
Member Author

I have updated local subrepos to the newest releases, everything works pretty well.

We will think with @magul if we should just update this repo (and continue updating), or we should also version it.

Some ideas are also

  1. Push images to registry
  2. Separate docker compose for backend-only, so if I want to use only backend, I dont want do build all frontend (slow)
  3. Use makefile for scripts

@patrys
Copy link
Member

patrys commented Mar 28, 2023

@lkostrowski Can we consider this one closed?

@lkostrowski
Copy link
Member Author

Looks like it 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion documentation Improvements or additions to documentation
Projects
No open projects
Status: 🔖 Ready for dev
Development

No branches or pull requests

4 participants