Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: You must provide specifications for the runner in your best config. #236

Open
mohanraj-r opened this issue Aug 6, 2020 · 1 comment

Comments

@mohanraj-r
Copy link

mohanraj-r commented Aug 6, 2020

I am not able to get a simple benchmark to run successfully following the instructions from Getting Started doc

Steps:

  • installed "@best/cli", "@best/runner-headless" (latest versions as of Aug 5)
  • added a simple benchmark.js file
  • added best.config.js as per doc
module.exports = {
    projectName: 'sa11y-benchmarks',
    testMatch: ['packages/assert/__benchmarks__/rules.benchmark.js'],
};

Running yarn best gives error

$ yarn best
yarn run v1.22.4
$ ./node_modules/.bin/best

 Building benchmarks...

 Building benchmarks...
 Building benchmarks...

   DONE     (sa11y-benchmarks) packages/assert/__benchmarks__/rules.benchmark.js

 Running benchmarks...

  QUEUED    (sa11y-benchmarks) __benchmarks_results__/.../artifacts/rules.benchmark.html

  ERROR     Error: You must provide specifications for the runner in your best config.
    at runBenchmarksBundle (./node_modules/@best/runner/build/index.js:15:15)
    at Object.runBenchmarks (./node_modules/@best/runner/build/index.js:41:40)
    at Object.runBest (./node_modules/@best/cli/build/run_best.js:100:49)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async runCLI (./node_modules/@best/cli/build/cli/index.js:116:25)
    at async Object.run (./node_modules/@best/cli/build/cli/index.js:66:9)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Tried adding the following to best.config.js but the error persists

  1. runner: '@best/runner-headless',
  2. runnerConfig: [{ runner: '@best/runner-headless' }],
  3. runnerConfig: [{ runner: '@best/runner-headless', benchmarkRunnerConfig: {} }],
@Flomb38
Copy link

Flomb38 commented Apr 29, 2021

Looks like something like
specs: { name: 'chrome.headless', version: 80 },
is mandatory in best.config.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants