Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand static content optimization #4280

Closed
6 of 8 tasks
nolanlawson opened this issue Jun 11, 2024 · 3 comments
Closed
6 of 8 tasks

Expand static content optimization #4280

nolanlawson opened this issue Jun 11, 2024 · 3 comments

Comments

@nolanlawson
Copy link
Collaborator

nolanlawson commented Jun 11, 2024

Currently there are some HTML features that de-optimize a node and disqualify it for the static content optimization. We should fix these so that more HTML templates get the performance benefits of this optimization.

Copy link

git2gus bot commented Jun 11, 2024

This issue has been linked to a new work item: W-15983509

@nolanlawson
Copy link
Collaborator Author

Not sure we'll end up doing lwc:dom="manual" – it's tricky because it affects synthetic shadow and how "portals" are rendered (i.e. bits of DOM that need MutationObservers to add the synthetic shadow scope token attributes). It also overlaps some with lwc:inner-html due to that directive requiring a portal as well.

@nolanlawson
Copy link
Collaborator Author

I'm going to say this is good enough for now. lwc:dom="manual" can be optimized another way – by disabling it in disableSyntheticShadowSupport. For lwc:inner-html, it is rare enough that it may not be worth optimizing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant