Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BuildProperties bean in Spring Boot by writing META-INF/build-info.properties #113

Closed
plaird opened this issue Apr 23, 2021 · 4 comments

Comments

@plaird
Copy link
Contributor

plaird commented Apr 23, 2021

The BuildProperties bean in Spring Boot is loaded from data populated in META-INF/build-info.properties

It allows for custom properties to be added. We should support that too.

@plaird
Copy link
Contributor Author

plaird commented Dec 23, 2024

I don't see the value in this. The git.properties data for us has been helpful, but we have never wanted the data that comes from build.properties (maven gav).

If you have a real use case where build-info.properties provides value, where git.properties can't, let me know. Otherwise this will remain unworked.

@plaird
Copy link
Contributor Author

plaird commented Dec 23, 2024

There is a reference to a use case involving build-info.properties here #205 , but not clear how important the file is.

@plaird
Copy link
Contributor Author

plaird commented Jan 8, 2025

Coincidentally, we found a use case internally. A team wants CI build data published into BuildProperties. We found that there was nothing general purpose to bake into rules_spring, but we can provide an example.

@plaird
Copy link
Contributor Author

plaird commented Jan 8, 2025

The example has been added to demoapp as #258

@plaird plaird closed this as completed Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant