Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share button does not do anything on desktop #126

Open
sloorush opened this issue Jan 2, 2023 · 2 comments
Open

Share button does not do anything on desktop #126

sloorush opened this issue Jan 2, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@sloorush
Copy link

sloorush commented Jan 2, 2023

I used the website on brave browser, and the share button does not do anything, download the image buttons work perfectly.

I guess this is like a share popup in mobile browsers.

Possible solutions:

  • Make a custom share popup
  • Check for prebuilt share popups (like the mobile ones but for desktop) (browser native or otherwise)
  • Meanwhile, remove the button if the device is not supported

Please do comment if this is something that is only happening on my PC.

Thanks, pretty cool project!

@sallar
Copy link
Owner

sallar commented Jan 2, 2023

The Share button is displayed only if navigator.share is available but I think Brave can't display the share sheet for images. There is a navigator.canShare(...) API that I should be using instead to check the availability. Will do that.

@sloorush
Copy link
Author

sloorush commented Jan 2, 2023

Sounds like a solution, thanks!

@sallar sallar added the bug Something isn't working label Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants