Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodSpeed Benchmarks to CI #533

Merged
merged 2 commits into from
Jul 28, 2024
Merged

Conversation

MichaReiser
Copy link
Contributor

@MichaReiser MichaReiser commented Jul 26, 2024

This PR is based on #529

This PR adds a CI step to run the benchmarks with codspeed. This gives us a similar experience to astral-sh/ruff#12406 (comment)

I don't have the necessary permissions to finish the setup myself.

  1. Add the repository to codspeed
  2. Add the access token (named CODSPEED_TOKEN)

We'll need to create a access token and add it. I don't have the necessary permissions. See

Copy link

netlify bot commented Jul 26, 2024

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit d94e342
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/66a372938b629b00089ab3cf

@MichaReiser MichaReiser changed the base branch from master to fix-guard-assertion July 26, 2024 09:56
@MichaReiser MichaReiser marked this pull request as draft July 26, 2024 09:57
@MichaReiser MichaReiser marked this pull request as ready for review July 26, 2024 10:02
@nikomatsakis
Copy link
Member

Interesting, I had never heard of codspeed. Working on it!

@nikomatsakis
Copy link
Member

OK, the token exists now

Copy link

codspeed-hq bot commented Jul 28, 2024

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 1 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

  • many_tracked_structs (134.7 µs)

Copy link
Member

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's working...

@nikomatsakis nikomatsakis merged commit 98eefd6 into fix-guard-assertion Jul 28, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants