-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test tracing, fix up comments #544
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #544 will not alter performanceComparing Summary
|
examples/calc/parser.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably want to revert this change, considering that it is part of your other PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased this PR on that one to get the tests passing here, then noticed that since I pushed the branch to my own fork I couldn't actually set the PR base branch to the other PRs branch, so the commit from the other branch is included here. Once the other PR is merged I can rebase this one. (Or I can rebase it sooner and just let the tests fail.)
@carljm looks good to me but needs to be rebased. feel free to merge. |
@nikomatsakis Rebased, but I can't merge; it says "Merging is blocked: The base branch restricts merging to authorized users." |
This PR does two things:
Add the
trace
feature for thetest-log
dependency, which I've found very useful in trying to understand the cycle-handling code. It means that I can change#[test]
to#[test_log::test]
above a failing test of interest, and then if I runcargo test
with e.g.RUST_LOG=debug
, the failing test output will include all the debug traces from that test.Fix up a bunch of comments and some debug traces I ran across in my exploration that looked out of date.
Happy to split this into two PRs if that's preferred.