Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the verbosity of Salsa's tracing output.
Salsa used to include the
Memo
value in the tracing output. If the value is large (imagine a file's source text or AST), this can lead to very verbose traces.This PR introduces a new
tracing_debug
function onMemo
that omitsvalue
and only includes whether theMemo
's value isSome
orNone
.I considered chagning
Memo
'sDebug
implementation but I can see cases where it might be useful to debug print aMemo
including its value when debugging a Salsa issue.The output of
Memo.revisions
can still be long if a query has many dependencies but seeing the outputs is useful when debugging SalsaTest plan
I used a field-level tracing filter in Ruff and the Salsa output looks very manageable now.