feat(client): add tests/ gift card API/ multiple fixes

.github/workflows/python-app.yml

@@ -26,10 +26,8 @@ jobs:
       run: pip install ruff
     - name: Lint code with Ruff
       run: ruff check --output-format=github --target-version=py39 .
-      continue-on-error: false # TODO: delete once ruff errors are fixed
-    # - name: Check code formatting with Ruff
-    #   run: ruff format --check .
-    #   continue-on-error: false # TODO: delete once ruff errors are fixed
+    - name: Check code formatting with Ruff
+      run: ruff format --check .
 
   build:
     needs: lint
@@ -42,6 +40,7 @@ jobs:
       TEST_FUTURES_API_KEY: "227719da8d8499e8d3461587d19f259c0b39c2b462a77c9b748a6119abd74401"
       TEST_FUTURES_API_SECRET: "b14b935f9cfacc5dec829008733c40da0588051f29a44625c34967b45c11d73c"
     strategy:
+      max-parallel: 1
       matrix:
         python: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12"]
     steps:

README.rst

@@ -79,6 +79,7 @@ Features
 - Vanilla Options
 - Proxy support
 - Support other domains (.us, .jp, etc)
+- Support for the Gift Card API
 
 Upgrading to v1.0.0+
 --------------------

binance/async_client.py

@@ -131,59 +131,64 @@ async def _request_api(
         **kwargs,
     ):
         uri = self._create_api_uri(path, signed, version)
-        return await self._request(method, uri, signed, **kwargs)
+        force_params = kwargs.pop("force_params", False)
+        return await self._request(method, uri, signed, force_params, **kwargs)
 
     async def _request_futures_api(
         self, method, path, signed=False, version=1, **kwargs
     ) -> Dict:
         version = self._get_version(version, **kwargs)
         uri = self._create_futures_api_uri(path, version=version)
-
-        return await self._request(method, uri, signed, False, **kwargs)
+        force_params = kwargs.pop("force_params", False)
+        return await self._request(method, uri, signed, force_params, **kwargs)
 
     async def _request_futures_data_api(
         self, method, path, signed=False, **kwargs
     ) -> Dict:
         uri = self._create_futures_data_api_uri(path)
-
-        return await self._request(method, uri, signed, True, **kwargs)
+        force_params = kwargs.pop("force_params", True)
+        return await self._request(method, uri, signed, force_params, **kwargs)
 
     async def _request_futures_coin_api(
         self, method, path, signed=False, version=1, **kwargs
     ) -> Dict:
         version = self._get_version(version, **kwargs)
         uri = self._create_futures_coin_api_url(path, version=version)
-
-        return await self._request(method, uri, signed, False, **kwargs)
+        force_params = kwargs.pop("force_params", False)
+        return await self._request(method, uri, signed, force_params, **kwargs)
 
     async def _request_futures_coin_data_api(
         self, method, path, signed=False, version=1, **kwargs
     ) -> Dict:
         version = self._get_version(version, **kwargs)
         uri = self._create_futures_coin_data_api_url(path, version=version)
 
-        return await self._request(method, uri, signed, True, **kwargs)
+        force_params = kwargs.pop("force_params", True)
+        return await self._request(method, uri, signed, force_params, **kwargs)
 
     async def _request_options_api(self, method, path, signed=False, **kwargs) -> Dict:
         uri = self._create_options_api_uri(path)
+        force_params = kwargs.pop("force_params", True)
 
-        return await self._request(method, uri, signed, True, **kwargs)
+        return await self._request(method, uri, signed, force_params, **kwargs)
 
     async def _request_margin_api(
         self, method, path, signed=False, version=1, **kwargs
     ) -> Dict:
         version = self._get_version(version, **kwargs)
         uri = self._create_margin_api_uri(path, version)
 
-        return await self._request(method, uri, signed, **kwargs)
+        force_params = kwargs.pop("force_params", False)
+        return await self._request(method, uri, signed, force_params, **kwargs)
 
     async def _request_papi_api(
         self, method, path, signed=False, version=1, **kwargs
     ) -> Dict:
         version = self._get_version(version, **kwargs)
         uri = self._create_papi_api_uri(path, version)
 
-        return await self._request(method, uri, signed, **kwargs)
+        force_params = kwargs.pop("force_params", False)
+        return await self._request(method, uri, signed, force_params, **kwargs)
 
     async def _request_website(self, method, path, signed=False, **kwargs) -> Dict:
         uri = self._create_website_uri(path)
@@ -1768,17 +1773,28 @@ async def futures_create_order(self, **params):
             params["newClientOrderId"] = self.CONTRACT_ORDER_PREFIX + self.uuid22()
         return await self._request_futures_api("post", "order", True, data=params)
 
+    async def futures_modify_order(self, **params):
+        """Modify an existing order. Currently only LIMIT order modification is supported.
+
+        https://binance-docs.github.io/apidocs/futures/en/#modify-order-trade
+
+        """
+        return await self._request_futures_api("put", "order", True, data=params)
+
     async def futures_create_test_order(self, **params):
         return await self._request_futures_api("post", "order/test", True, data=params)
 
     async def futures_place_batch_order(self, **params):
         for order in params["batchOrders"]:
             if "newClientOrderId" not in order:
                 order["newClientOrderId"] = self.CONTRACT_ORDER_PREFIX + self.uuid22()
-        query_string = urlencode(params)
-        query_string = query_string.replace("%27", "%22")
+                order = self._order_params(order)
+        query_string = urlencode(params).replace("%40", "@").replace("%27", "%22")
         params["batchOrders"] = query_string[12:]
-        return await self._request_futures_api("post", "batchOrders", True, data=params)
+
+        return await self._request_futures_api(
+            "post", "batchOrders", True, data=params, force_params=True
+        )
 
     async def futures_get_order(self, **params):
         return await self._request_futures_api("get", "order", True, data=params)
@@ -1799,7 +1815,7 @@ async def futures_cancel_all_open_orders(self, **params):
 
     async def futures_cancel_orders(self, **params):
         return await self._request_futures_api(
-            "delete", "batchOrders", True, data=params
+            "delete", "batchOrders", True, data=params, force_params=True
         )
 
     async def futures_countdown_cancel_all(self, **params):
@@ -2029,7 +2045,7 @@ async def futures_coin_cancel_order(self, **params):
 
     async def futures_coin_cancel_all_open_orders(self, **params):
         return await self._request_futures_coin_api(
-            "delete", "allOpenOrders", signed=True, data=params
+            "delete", "allOpenOrders", signed=True, data=params, force_params=True
         )
 
     async def futures_coin_cancel_orders(self, **params):
@@ -3594,3 +3610,51 @@ async def ws_futures_account_status(self, **params):
         https://developers.binance.com/docs/derivatives/usds-margined-futures/account/websocket-api/Account-Information
         """
         return await self._ws_futures_api_request("account.status", True, params)
+
+    ####################################################
+    # Gift Card API Endpoints
+    ####################################################
+
+    async def gift_card_fetch_token_limit(self, **params):
+        return await self._request_margin_api(
+            "get", "giftcard/buyCode/token-limit", signed=True, data=params
+        )
+
+    gift_card_fetch_token_limit.__doc__ = Client.gift_card_fetch_token_limit.__doc__
+
+    async def gift_card_fetch_rsa_public_key(self, **params):
+        return await self._request_margin_api(
+            "get", "giftcard/cryptography/rsa-public-key", signed=True, data=params
+        )
+
+    gift_card_fetch_rsa_public_key.__doc__ = (
+        Client.gift_card_fetch_rsa_public_key.__doc__
+    )
+
+    async def gift_card_verify(self, **params):
+        return await self._request_margin_api(
+            "get", "giftcard/verify", signed=True, data=params
+        )
+
+    gift_card_verify.__doc__ = Client.gift_card_verify.__doc__
+
+    async def gift_card_redeem(self, **params):
+        return await self._request_margin_api(
+            "post", "giftcard/redeemCode", signed=True, data=params
+        )
+
+    gift_card_redeem.__doc__ = Client.gift_card_redeem.__doc__
+
+    async def gift_card_create(self, **params):
+        return await self._request_margin_api(
+            "post", "giftcard/createCode", signed=True, data=params
+        )
+
+    gift_card_create.__doc__ = Client.gift_card_create.__doc__
+
+    async def gift_card_create_dual_token(self, **params):
+        return await self._request_margin_api(
+            "post", "giftcard/buyCode", signed=True, data=params
+        )
+
+    gift_card_create_dual_token.__doc__ = Client.gift_card_create_dual_token.__doc__

binance/base_client.py

@@ -206,6 +206,7 @@ def __init__(
     def _get_headers(self) -> Dict:
         headers = {
             "Accept": "application/json",
+            "Content-Type": "application/json",
             "User-Agent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36",  # noqa
         }
         if self.API_KEY: