Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FfmpegAdapter] #write_errors should create exit code file to indicate failed status #130

Open
cjcolvar opened this issue Nov 29, 2023 · 0 comments

Comments

@cjcolvar
Copy link
Member

def write_errors(encode)
File.write(working_path("error.log", encode.id), encode.errors.join("\n"))
end

#write_errors writes out an error.log file but not an exit_status.code which gets used in determining the status in the #find method

exit_code = read_exit_code(id)
if exit_code.present? && exit_code != 0 && exit_code != 143
encode.state = :failed

This leads to an issue along with #129 when a file fails in #create during inspection.

Alternatively the #find if statements could be changed to check for error.log. Although this might not work since the ffmpeg command outputs to error.log for stderr which might happen even when the command is still running or succeeds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant