-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid accessing memebers in Implementation namespaces #906
Comments
Looks like @ibaned might have put this in based on some const issues? See 7c34226#diff-f65ed18732c81ee5d12806153e9984789d4aca4f6bdbc649866b2dd65992e244R224 & #34 Unless it predates that merge and it was moved around. Dan is there an easy way to get rid of this? No problem if you don't recall what the original issue was. It looks like |
Yea, I have no memory of this. I would recommend either opening and issue on the Kokkos GitHub repository or asking on the Kokkos Slack channel what the best way is to write these |
I have no clue what those routines are trying to achieve. I am also not a big expert of DynRankView details. I think Dan is right, asking on kokkos channels might be a good idea. |
We are using functions/classes in
Impl
namespaces.This is not recommended because functions/classes in
Impl
namespaces can change frequently. Kokkos developers are pushing applications to avoid doing so.@jewatkins @kliegeois @bartgol any volunteer to address this issue?
The text was updated successfully, but these errors were encountered: