Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: search #7838

Draft
wants to merge 9 commits into
base: next
Choose a base branch
from
Draft

feat: search #7838

wants to merge 9 commits into from
+881 −20

Conversation

juice49
Copy link
Contributor

@juice49 juice49 commented Nov 18, 2024

Description

What to review

Testing

Notes for release

@vercel Vercel
Copy link

vercel bot commented Nov 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 2:54pm
performance-studio ✅ Ready (Inspect) Visit Preview Nov 29, 2024 2:54pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 2:54pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 2:54pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 2:54pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 2:54pm

@vercel vercel bot temporarily deployed to Preview – page-building-studio November 18, 2024 21:34 Inactive
@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024 •
edited
Loading

Component Testing Report Updated Nov 29, 2024 2:47 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 51s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 39s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 47s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 41s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 18s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 27s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 19s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 39s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024 •
edited
Loading

⚡️ Editor Performance Report

Updated Fri, 29 Nov 2024 14:45:58 GMT

Benchmark reference
latency of sanity@latest		 experiment
latency of this branch		 Δ (%)
latency difference
article (title) 23.8 efps (42ms) 23.3 efps (43ms) +1ms (+2.4%) ✅
article (body) 53.5 efps (19ms) 59.3 efps (17ms) -2ms (-9.9%) ✅
article (string inside object) 25.6 efps (39ms) 26.7 efps (38ms) -2ms (-3.8%) ✅
article (string inside array) 23.3 efps (43ms) 23.3 efps (43ms) +0ms (-/-%) ✅
recipe (name) 43.5 efps (23ms) 43.5 efps (23ms) +0ms (-/-%) ✅
recipe (description) 50.0 efps (20ms) 50.0 efps (20ms) +0ms (-/-%) ✅
recipe (instructions) 99.9+ efps (10ms) 99.9+ efps (7ms) -3ms (-/-%) ✅
synthetic (title) 17.9 efps (56ms) 18.2 efps (55ms) -1ms (-1.8%) ✅
synthetic (string inside object) 19.2 efps (52ms) 19.2 efps (52ms) +0ms (-/-%) ✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 42ms 45ms 49ms 190ms 183ms 10.7s
article (body) 19ms 22ms 42ms 227ms 514ms 6.3s
article (string inside object) 39ms 46ms 57ms 374ms 509ms 7.7s
article (string inside array) 43ms 46ms 53ms 203ms 158ms 7.3s
recipe (name) 23ms 25ms 31ms 86ms 31ms 8.8s
recipe (description) 20ms 22ms 23ms 32ms 0ms 4.9s
recipe (instructions) 10ms 11ms 13ms 38ms 0ms 3.6s
synthetic (title) 56ms 59ms 76ms 295ms 828ms 14.0s
synthetic (string inside object) 52ms 55ms 65ms 463ms 920ms 8.5s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 43ms 47ms 53ms 223ms 201ms 11.5s
article (body) 17ms 19ms 24ms 51ms 197ms 5.6s
article (string inside object) 38ms 40ms 53ms 200ms 171ms 6.9s
article (string inside array) 43ms 46ms 53ms 169ms 225ms 7.2s
recipe (name) 23ms 26ms 35ms 95ms 13ms 9.2s
recipe (description) 20ms 21ms 24ms 46ms 0ms 5.0s
recipe (instructions) 7ms 9ms 11ms 27ms 0ms 3.5s
synthetic (title) 55ms 63ms 79ms 354ms 760ms 13.1s
synthetic (string inside object) 52ms 56ms 68ms 397ms 622ms 8.9s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@juice49
fix(sanity): reset search cursor when any parameter changes
92b1ad8
@juice49
refactor(sanity): skip unnecessary deduplication step
8a54e3f 
It's only necessary to deduplicate search results when using the
Text Search API, because this API sometimes produces duplicate results
at page boundaries.
@juice49
feat: add groq2024 search strategy option
a710cb1
@juice49
wip(sanity): groq2024 search
857adde
@juice49
feat(sanity): do not fade out global search results while fetching more
8fd5c14 
Search results now only fade out when input parameters change,
reflecting that the results that have already been loaded no longer
match the input parameters.

They no longer fade out when fetching more results for the same set of
input parameters.
@juice49
wip: path exclusion
bd3ced7
@juice49
refactor(sanity): remove unused search exclusion builder code
c719e5c
@juice49
feat(test-studio): enable new search in staging workspace
1c04d3f
@juice49
fix(sanity): do not perform incremental search for exact tokens
2b21e35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@juice49