From dcf4aa85a31b47a2380d4e29964ce413d12ccd40 Mon Sep 17 00:00:00 2001 From: Roger Braunstein Date: Sun, 15 Sep 2024 16:17:01 -0700 Subject: [PATCH] Fix for overdumping Electrocop/Lynx --- Cart_Reader/LYNX.ino | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Cart_Reader/LYNX.ino b/Cart_Reader/LYNX.ino index 29010caf..001ed279 100644 --- a/Cart_Reader/LYNX.ino +++ b/Cart_Reader/LYNX.ino @@ -40,7 +40,7 @@ // | 34 |- SWVCC // +----+ // -// Version 1.1 +// Version 1.2 // By @partlyhuman // This implementation would not be possible without the invaluable // documentation on @@ -125,9 +125,11 @@ static bool waitPressButton_LYNX(bool ret = false) { static void compareStride_LYNX(uint8_t b, int i, int stride) { uint8_t other = readByte_LYNX(i + stride); - if (other == 0xff) { - // If this is a flash cart, these in-between spaces should be formatted to all 1's + if (other == 0xff || other == 0x00) { + // If this is NOR flash, these in-between spaces should be formatted to all 1's // in which case, we DON'T report this as an unmirrored area + // Additionally, we have encountered commercial carts where the maskrom is larger than it needs to be + // and in this case, the maskrom will be initialized to 0s, not 1s. return; } if (b != other) {