Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide additional links to different sources for the same work #59

Open
funderburkjim opened this issue Jun 26, 2022 · 9 comments
Open

Comments

@funderburkjim
Copy link
Contributor

funderburkjim commented Jun 26, 2022

This suggestion was made in this comment.

The idea is that a given literary source reference might have multiple link targets.
Rg Veda is a case in point, where there are web sites that present the verses according to different principles. For example, the current link-target for Rg veda at CDSL does not contain accents in the IAST form : rv 3,55,19. Probably there are now digitized sources (perhaps at Titus) from which an accented IAST link target could be made available; this was mentioned as desireable several years ago by @SergeA. Also, there are good audio sources of Rg veda recitations, which could be used as link targets.

Thus, there are certainly reasons in favor of having the ability, in dictionary displays, to link to multiple targets.

@funderburkjim
Copy link
Contributor Author

UI

The html for link targets in current cdsl displays uses a simple html anchor (along with a tooltip and a little bit of CSS styling).

<a 
href="https://sanskrit-lexicon.github.io/rvlinks/rvhymns/rv03.055.html#rv03.055.19" 
title="ṚV. = ṚGVEDA. Es wird nach Maṇḍala, Sūkta und Ṛc citirt. ROSEN zu ṚV. verweist auf die Anmerkungen in: Rigveda-Sanhita, liber primus, sanskritè et latinè; edidit FRIDERICUS ROSEN. London 1838." style="text-decoration: none; border-bottom: 1px dotted #000;" 
target="_rvlink">
 <span style="color:blue;" class="ls">Ṛv.</span><span class="ls"> 3, 55, 19.</span>
</a>

To allow multiple links, we would need some other UI, within which, one of several link targets could be chosen by the user. One possibility is illustrated in Wikipedia:

image

Perhaps other users will have different candidates for such UI enhancement.

If we decide on a desired UI, then to make the suggestion a reality, we will need

  • additional link targets for some literary sources
  • appropriate Javascript and CSS and html markup
  • integration into the basicadjust/basicdisplay php programs.

@gasyoun
Copy link
Member

gasyoun commented Jun 26, 2022

To allow multiple links, we would need some other UI, within which, one of several link targets could be chosen by the user.

So you want the target to be reached in 2 steps instead of 1?

@Andhrabharati
Copy link

To allow multiple links, we would need some other UI, within which, one of several link targets could be chosen by the user.

So you want the target to be reached in 2 steps instead of 1?

You seem to have clearly misunderstood the point @gasyoun ,
what is being discussed is having multiple links together (user-selectable individually),

like done for 'roots' in MW (Westergaard and Whitney)

(as I had mentioned in my suggestion in the other thread #57 (comment))

The links to individual targets will be placed side-by-side, and the user can click on anyone that he wants to see.

@funderburkjim
Copy link
Contributor Author

In MW display, the links to Whitney or Westergaard are put BEFORE the body of an entry. There are always just a very small number of such links.

By contrast, a PWG entry might have dozens of links to Rg veda., and or to AV or R, etc. It would be confusing to show those at the beginning of an entry.

So the multiple link targets in PWG must be placed in line(as currently). The Wikipedia approach seems to be one UI which might be adapted to this goal.

@gasyoun
Copy link
Member

gasyoun commented Jun 28, 2022

So the multiple link targets in PWG must be placed in line(as currently). The Wikipedia approach seems to be one UI which might be adapted to this goal.

Agree

In MW display, the links to Whitney or Westergaard are put BEFORE the body of an entry. There are always just a very small number of such links.

And even there Westergaard is not incorporated IN, but ONLY before. We could remove Westergaard from BEFORE and leave add only IN.

The links to individual targets will be placed side-by-side, and the user can click on anyone that he wants to see.

Still do not see the need for a side-by-side. Rahter I'm for a single aggregated one.

@gasyoun
Copy link
Member

gasyoun commented Oct 7, 2024

agni

@funderburkjim why both links broken?

@funderburkjim
Copy link
Contributor Author

Both links are broken because each has only 2 parameters.

@gasyoun
Copy link
Member

gasyoun commented Oct 8, 2024

Both links are broken because each has only 2 parameters.

Guess they are not the only ones

funderburkjim added a commit to sanskrit-lexicon/csl-websanlexicon that referenced this issue Oct 8, 2024
@funderburkjim
Copy link
Contributor Author

funderburkjim commented Oct 8, 2024

Made a change to basicadjust.php. Now the 2-parameter links (as in the agni example above) are not broken -- they assume the missing 3rd parameter is 1 (1st verse). This change applies to pwg, pw, and pwkvn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants