Skip to content
This repository has been archived by the owner on May 29, 2020. It is now read-only.

v1.3.1 - Build Failed on Windows #332

Open
jeradrutnam opened this issue May 3, 2016 · 2 comments
Open

v1.3.1 - Build Failed on Windows #332

jeradrutnam opened this issue May 3, 2016 · 2 comments
Labels

Comments

@jeradrutnam
Copy link

jeradrutnam commented May 3, 2016

Checked latest release 1.3.1 and noticed it breaks the build. And the change that cause this issue is,

grunt-webfont\tasks\engines\fontforge.js
var exec = require('exec'); => require('child_process').exec;

var args = [ 'fontforge', '-script', path.join(__dirname, 'fontforge/generate.py')    
];   =>   ].join(' ');

If you revert that, it will work just fine. :)

Can send a PR if you think of reverting it back.

@jeradrutnam jeradrutnam changed the title v1.3.1 - Build Faild (Windows) v1.3.1 - Build Failed on Windows May 3, 2016
@jeradrutnam
Copy link
Author

jeradrutnam commented Jun 19, 2016

Hi @sapegin, Just checking about the issue. Are we going to change it or will this effect something else?

@sapegin
Copy link
Owner

sapegin commented Jun 20, 2016

I can’t revert it because exec module is deprecated. There should be a correct solution.

@sapegin sapegin added the bug label Jun 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants